Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show facehugger limit when examining eggs/morphers #6386

Merged
merged 41 commits into from
Jun 19, 2024

Conversation

zzzmike
Copy link
Contributor

@zzzmike zzzmike commented Jun 6, 2024

About the pull request

When you examine a hive core, it tells you the lesser drone limit, and the current amount of lesser drones. This adds a similar behavior for eggs and morphers with regards to playable facehuggers.

Explain why it's good for the game

Helpful for ghosts to decide whether to play hugger, drone, neither, or just for information.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: examining eggs/morphers tells you current number of huggers and the limit
/:cl:

@github-actions github-actions bot added the Quality of Life Make the game harder to play label Jun 6, 2024
@zzzmike zzzmike marked this pull request as draft June 6, 2024 03:10
@zzzmike zzzmike marked this pull request as ready for review June 6, 2024 23:14
harryob
harryob previously requested changes Jun 8, 2024
code/modules/cm_aliens/structures/egg.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/structures/special/egg_morpher.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/hive_status.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 8, 2024 07:26
@zzzmike zzzmike marked this pull request as ready for review June 8, 2024 08:00
@zzzmike zzzmike requested a review from harryob June 8, 2024 08:01
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 19, 2024
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To use the same formatting as lesser examines.

image

code/modules/cm_aliens/structures/egg.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/structures/special/egg_morpher.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar removed the Stale beg a maintainer to review your PR label Jun 19, 2024
@Drulikar Drulikar marked this pull request as draft June 19, 2024 01:45
@zzzmike zzzmike marked this pull request as ready for review June 19, 2024 23:27
@zzzmike zzzmike requested a review from Drulikar June 19, 2024 23:31
@Drulikar Drulikar added this pull request to the merge queue Jun 19, 2024
Merged via the queue into cmss13-devs:master with commit 6864722 Jun 19, 2024
28 checks passed
cm13-github added a commit that referenced this pull request Jun 19, 2024
@zzzmike zzzmike deleted the patch-2 branch June 20, 2024 00:02
github-merge-queue bot pushed a commit that referenced this pull request Oct 5, 2024
# About the pull request

I kinda screwed up when adding this at
#6386 - there's no reason to
have the facehugger limit hidden from xenos, the lesser drone limit is
already visible to xenos when examining hive core.

# Explain why it's good for the game

Parity with lesser drone limit visibility.


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
qol: facehugger limit is visible when examining eggs/morpher as xeno,
akin to lesser drone limit when examining hive core
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Quality of Life Make the game harder to play
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants